Mailing List Archive


Back to the month index Back to the list index
sbeer@ibm.net
Tue, 01 Apr 97 07:15:40 +0000 

Message-Id: <9704011233.AA0061@YOUR-HOST-NAME>
Date: Tue, 01 Apr 97 07:15:40 +0000
From: sbeer@ibm.net
Subject: [mSQL] NOT NULL bug in Beta 5 fixed!

Larry Stone's fix for the NOT NULL bug worked for me.
I previously posted (also to 'bugs') a sample case where REAL seemed not to
work under beta 5. It now seems that the problem was with the
NOT NULL checking. Once Larry's simple fix is implemented, the problem
goes away!

By the way, I did not apply Larry's patch directly (see my version
below). Also, I did not apply at all the other patches he was
referring to (and apparently unrelated to this problem).
I hope Bambi catches all these issues for beta 6.

I also reported previously that the '1.2e34' format is not recognized.
Well, I now notice that '1.2e+34' works OK. In other words, exponent sign
is mandatory for scientific format, or so it seems.

//----------------------------------------------------------
// Steve Beer
// sbeer@ibm.net

--- msqldb.c.orig Mon Mar 17 00:33:19 1997
+++ msqldb.c Mon Mar 31 20:01:54 1997
@@ -528,16 +528,14 @@
         row_t *row;
 {
         REG field_t *curField;
- REG int offset;
         u_char *data;
 
         msqlTrace(TRACE_IN,"checkNullFields()");
         data = row->data;
- offset = 0;
         curField = cacheEntry->def;
         while(curField)
         {
- if (!*(data + offset) && (curField->flags & NOT_NULL_FLAG))
+ if (!data[curField->offset] && (curField->flags & NOT_NULL_FLAG))
                 {
                         sprintf(errMsg,BAD_NULL_ERROR, curField->name);
                         msqlDebug(MOD_ERR,"Field \"%s\" cannot be null\n",
@@ -545,7 +543,6 @@
                         msqlTrace(TRACE_OUT,"checkNullFields()");
                         return(-1);
                 }
- offset += curField->length + 1;
                 curField = curField->next;
         }
         msqlTrace(TRACE_OUT,"checkNullFields()");
--------------------------------------------------------------------------
To remove yourself from the Mini SQL mailing list send a message containing
"unsubscribe" to "unsubscribe" to msql-list-request@bunyip.com. Send a message containing
"info msql-list" to majordomo@bunyip.com for info on monthly archives of
the list. For more help, mail owner-msql-list@bunyip.com NOT the msql-list!